apex/DimDoors
1
1
Fork 0
Code Issues 26 Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid testing LinkData that does not belong to the same dimension #68

Closed
skyboy wants to merge 1 commits from master into master
pull from: master
merge into: apex:master
Conversation 0 Commits 1 Files Changed 1 +11354 -27831
skyboy commented 2013-08-16 08:41:44 +00:00 (Migrated from github.com)
Copy Link

This is a quick hot-fix for not only the NPE spam, but also doors being eaten by rifts.

The problem in both cases is that the LinkData's dimID ("dimHelper.getWorld(link.locDimID)") and the current dimID ("mod_pocketDim.blockRift.isBlockImmune(world, link.locXCoord, link.locYCoord, link.locZCoord)") are mismatched, causing the checked block to by from another dimension, eating doors (not detected) and causing NPEs (the dimension of the LinkData has been unloaded, or similarly causing the LinkData pulled in the onBlockAdded method to be null)

This does not fix the actual problem of the mismatch, but should temporarily patch the issue until the mismatching of LinkData dimension IDs is resolved

This is a quick hot-fix for not only the NPE spam, but also doors being eaten by rifts. The problem in both cases is that the LinkData's dimID ("dimHelper.getWorld(link.locDimID)") and the current dimID ("mod_pocketDim.blockRift.isBlockImmune(world, link.locXCoord, link.locYCoord, link.locZCoord)") are mismatched, causing the checked block to by from another dimension, eating doors (not detected) and causing NPEs (the dimension of the LinkData has been unloaded, or similarly causing the LinkData pulled in the onBlockAdded method to be null) This does not fix the actual problem of the mismatch, but should temporarily patch the issue until the mismatching of LinkData dimension IDs is resolved

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
apex
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: apex/DimDoors#68
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?