Fixed Golden Door Item ID Mishandling #156

2014-04-19T08:35:02Z

SenseiKiwi commented

2014-04-19 08:35:02 +00:00

(Migrated from github.com)

PLEASE READ THIS CAREFULLY.

Keybounce noticed that he was having a persistent item ID conflict with DD's Golden Doors - the normal doors not the dimensional variant. I discovered that we have been assigning them the same ID as the Golden Door block ever since they were first introduced 7 months ago. It didn't break immediately since Forge adds +256 to item IDs.

The impact of this is potentially serious but limited. By changing the default ID around, people may lose their Golden Door items unless they change their configs to account for this. This may also cause an item ID conflict to pop up. People have to be told to handle this. Fortunately, it's unlikely people have been stockpiling plain Golden Doors.

PLEASE READ THIS CAREFULLY. Keybounce noticed that he was having a persistent item ID conflict with DD's Golden Doors - the normal doors not the dimensional variant. I discovered that we have been assigning them the same ID as the Golden Door block ever since they were first introduced 7 months ago. It didn't break immediately since Forge adds +256 to item IDs. The impact of this is potentially serious but limited. By changing the default ID around, people may lose their Golden Door items unless they change their configs to account for this. This may also cause an item ID conflict to pop up. People have to be told to handle this. Fortunately, it's unlikely people have been stockpiling plain Golden Doors.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: apex/DimDoors#156