apex/DimDoors
1
1
Fork 0
Code Issues 26 Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed ClassCastException in DungeonPack #112

Merged
SenseiKiwi merged 1 commits from rewrite into master 2013-12-20 08:01:21 +00:00
Conversation 0 Commits 1 Files Changed 1 +8 -1
SenseiKiwi commented 2013-12-20 07:56:02 +00:00 (Migrated from github.com)
Copy Link

Fixed a bug in DungeonPack that would trigger a rare ClassCastException
during dungeon selection. We were comparing instances of DungeonType
against WeightedContainer. This wouldn't break dungeon
generation because DD falls back on selecting a random dungeon if
rule-based selection fails. It would allow duplicate dungeons to appear
in the same chain, though.

Fixed a bug in DungeonPack that would trigger a rare ClassCastException during dungeon selection. We were comparing instances of DungeonType against WeightedContainer<DungeonType>. This wouldn't break dungeon generation because DD falls back on selecting a random dungeon if rule-based selection fails. It would allow duplicate dungeons to appear in the same chain, though.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
apex
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: apex/DimDoors#112
No description provided.
Delete Branch "rewrite"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?