Fixed Pick Block Results #170

2014-07-07T08:40:02Z

SenseiKiwi commented

2014-07-07 08:40:02 +00:00

(Migrated from github.com)

We previously returned the Vanilla counterparts to our doors as the items to be used by the pick block button - used in Creative mode for replicating nearby blocks. This was incorrect because we would want to return the actual door item needed to place the particular door in question.

More importantly, this might solve our issues with WAILA reporting the wrong information when players look at our doors. I read the code for the most recent version of WAILA and it uses various functions to choose how to identify a block. The result of Block.idPicked() is probably used as the main source for the identities of our blocks.

After this PR went up, I also completed automatic versioning. Now we only have to update the version of DD in build.gradle and the change will be propagated to mod_pocketDim.java and mcmod.info.

We previously returned the Vanilla counterparts to our doors as the items to be used by the pick block button - used in Creative mode for replicating nearby blocks. This was incorrect because we would want to return the actual door item needed to place the particular door in question. More importantly, this might solve our issues with WAILA reporting the wrong information when players look at our doors. I read the code for the most recent version of WAILA and it uses various functions to choose how to identify a block. The result of Block.idPicked() is probably used as the main source for the identities of our blocks. --- After this PR went up, I also completed automatic versioning. Now we only have to update the version of DD in build.gradle and the change will be propagated to mod_pocketDim.java and mcmod.info.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: apex/DimDoors#170