Major Improvements to DungeonHelper, Minor Bug Fixes and Tweaks #25

Merged
SenseiKiwi merged 29 commits from master into master 2013-06-16 19:30:26 +00:00
SenseiKiwi commented 2013-06-16 05:37:06 +00:00 (Migrated from github.com)

Cleaned up and rewrote some of the code in DungeonHelper. More remains to be done, but the current changes have cut the length of the code and it'll be easier to maintain in the future. We also have zero compiler warnings in DungeonHelper now. Fixed a bug that caused duplication of dungeon entries in the listing command. Made the custom dungeon loading ignore the capitalization of dungeon type tags - it was silly for us not to load dungeons if the tags differed like that. Tweaked dungeon loot generation to make DD items very slightly rarer, enchanted books slightly more common.

Cleaned up and rewrote some of the code in DungeonHelper. More remains to be done, but the current changes have cut the length of the code and it'll be easier to maintain in the future. We also have zero compiler warnings in DungeonHelper now. Fixed a bug that caused duplication of dungeon entries in the listing command. Made the custom dungeon loading ignore the capitalization of dungeon type tags - it was silly for us not to load dungeons if the tags differed like that. Tweaked dungeon loot generation to make DD items very slightly rarer, enchanted books slightly more common.
SenseiKiwi commented 2013-06-16 14:56:00 +00:00 (Migrated from github.com)

Added another round of changes:

  1. Fixed mistakes in mcmod.info that made Forge ignore our mod information.
  2. IMPORTANT: Fixed the new properties for spawning rates of Monoliths and rift generationg. They were set to read from an existing property (because the code was copy-pasted), so the properties were broken. Depending on the order in which the faulty property was loaded, it could distort the spawning rates of Monoliths, rifts, and gateways, either making them absurdly common or far more rare than intended. I also rewrote the associated code and descriptions so that it's now much clearer how these settings will affect worlds.
  3. Made corrections to the dungeon tutorial and the code that copies it over.

And other improvements.

Added another round of changes: 1. Fixed mistakes in mcmod.info that made Forge ignore our mod information. 2. IMPORTANT: Fixed the new properties for spawning rates of Monoliths and rift generationg. They were set to read from an existing property (because the code was copy-pasted), so the properties were broken. Depending on the order in which the faulty property was loaded, it could distort the spawning rates of Monoliths, rifts, and gateways, either making them absurdly common or far more rare than intended. I also rewrote the associated code and descriptions so that it's now much clearer how these settings will affect worlds. 3. Made corrections to the dungeon tutorial and the code that copies it over. And other improvements.
SenseiKiwi commented 2013-06-16 18:44:11 +00:00 (Migrated from github.com)

Another round of changes. This time, I overhauled RiftGenerator into a thing of beauty, switched our Hashtables to HashMap (good advice), and made some other trivial changes.

Another round of changes. This time, I overhauled RiftGenerator into a thing of beauty, switched our Hashtables to HashMap (good advice), and made some other trivial changes.
StevenRS11 commented 2013-06-16 19:30:49 +00:00 (Migrated from github.com)

Yay, more carbon fiber and less ductape!

Yay, more carbon fiber and less ductape!
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: apex/DimDoors#25
No description provided.