apex/DimDoors
1
1
Fork 0
Code Issues 26 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix possible NPE in RiftRegenerator.regenerate() #90

Merged
agaricusb merged 1 commits from patch-1 into master 2013-10-15 22:12:19 +00:00
Conversation 0 Commits 1 Files Changed 1 +4 -1
agaricusb commented 2013-10-07 02:15:44 +00:00 (Migrated from github.com)
Copy Link

After updating to DimDoors 1.5.2R1.4.1RC1-228 (from an older world which was running 1.5.2R1.3.6RC1-67 on 1.5.1), I started getting this log message every 100 ticks:

18:34:42 [SEVERE] An exception occurred in RiftRegenerator.regenerate():
18:34:42 [SEVERE] java.lang.NullPointerException
18:34:42 [SEVERE] at StevenDimDoors.mod_pocketDim.ticking.RiftRegenerator.regenerate(RiftRegenerator.java:60)
18:34:42 [SEVERE] at StevenDimDoors.mod_pocketDim.ticking.RiftRegenerator.notifyTick(RiftRegenerator.java:27)
18:34:42 [SEVERE] at StevenDimDoors.mod_pocketDim.ticking.CommonTickHandler.tickEnd(CommonTickHandler.java:59)
18:34:42 [SEVERE] at cpw.mods.fml.common.SingleIntervalHandler.tickEnd(SingleIntervalHandler.java:34)
18:34:42 [SEVERE] at cpw.mods.fml.common.FMLCommonHandler.tickEnd(FMLCommonHandler.java:141)
18:34:42 [SEVERE] at cpw.mods.fml.common.FMLCommonHandler.onPostServerTick(FMLCommonHandler.java:274)
18:34:42 [SEVERE] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:763)
18:34:42 [SEVERE] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:612)
18:34:42 [SEVERE] at net.minecraft.server.ThreadMinecraftServer.run(SourceFile:573)

Not exactly sure what is going on here (corrupted TE?) but adding a null check fixed the log spam, with no apparent ill effect.

(more details at https://gist.github.com/agaricusb/6694659)

After updating to DimDoors 1.5.2R1.4.1RC1-228 (from an older world which was running 1.5.2R1.3.6RC1-67 on 1.5.1), I started getting this log message every 100 ticks: 18:34:42 [SEVERE] An exception occurred in RiftRegenerator.regenerate(): 18:34:42 [SEVERE] java.lang.NullPointerException 18:34:42 [SEVERE] at StevenDimDoors.mod_pocketDim.ticking.RiftRegenerator.regenerate(RiftRegenerator.java:60) 18:34:42 [SEVERE] at StevenDimDoors.mod_pocketDim.ticking.RiftRegenerator.notifyTick(RiftRegenerator.java:27) 18:34:42 [SEVERE] at StevenDimDoors.mod_pocketDim.ticking.CommonTickHandler.tickEnd(CommonTickHandler.java:59) 18:34:42 [SEVERE] at cpw.mods.fml.common.SingleIntervalHandler.tickEnd(SingleIntervalHandler.java:34) 18:34:42 [SEVERE] at cpw.mods.fml.common.FMLCommonHandler.tickEnd(FMLCommonHandler.java:141) 18:34:42 [SEVERE] at cpw.mods.fml.common.FMLCommonHandler.onPostServerTick(FMLCommonHandler.java:274) 18:34:42 [SEVERE] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:763) 18:34:42 [SEVERE] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:612) 18:34:42 [SEVERE] at net.minecraft.server.ThreadMinecraftServer.run(SourceFile:573) Not exactly sure what is going on here (corrupted TE?) but adding a null check fixed the log spam, with no apparent ill effect. (more details at https://gist.github.com/agaricusb/6694659)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
apex
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: apex/DimDoors#90
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?