I don't have much time to go into detail about this so I'll have to make it quick. Our code seems to be reliant on door-type blocks and doesn't support trapdoors properly. For instance, placing a Dimensional Door, then breaking it and attaching a Transdimensional Trapdoor causes an exception and the door slams shut. I'm fairly certain that other issues would arise if that code could continue running. At some point, traverseDimDoor() got a parameter "Block door". A lot of code seems to assume that block is going to be a normal door and not a trapdoor.
I also noticed that some function in PocketBuilder requires us to sent it a Block that implements IDimDoor. Maybe we should consider changing the parameter to BaseDimDoor? Or at least BlockDoor. Especially if we're going to use ItemDoor to place the block.
I don't have much time to go into detail about this so I'll have to make it quick. Our code seems to be reliant on door-type blocks and doesn't support trapdoors properly. For instance, placing a Dimensional Door, then breaking it and attaching a Transdimensional Trapdoor causes an exception and the door slams shut. I'm fairly certain that other issues would arise if that code could continue running. At some point, traverseDimDoor() got a parameter "Block door". A lot of code seems to assume that block is going to be a normal door and not a trapdoor.
I also noticed that some function in PocketBuilder requires us to sent it a Block that implements IDimDoor. Maybe we should consider changing the parameter to BaseDimDoor? Or at least BlockDoor. Especially if we're going to use ItemDoor to place the block.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
I don't have much time to go into detail about this so I'll have to make it quick. Our code seems to be reliant on door-type blocks and doesn't support trapdoors properly. For instance, placing a Dimensional Door, then breaking it and attaching a Transdimensional Trapdoor causes an exception and the door slams shut. I'm fairly certain that other issues would arise if that code could continue running. At some point, traverseDimDoor() got a parameter "Block door". A lot of code seems to assume that block is going to be a normal door and not a trapdoor.
I also noticed that some function in PocketBuilder requires us to sent it a Block that implements IDimDoor. Maybe we should consider changing the parameter to BaseDimDoor? Or at least BlockDoor. Especially if we're going to use ItemDoor to place the block.