apex/DimDoors
1
1
Fork 0
Code Issues 26 Pull Requests Actions Packages Projects Releases Wiki Activity

Transdimensional Trapdoors cause Problems #150

New Issue
Open
opened 2014-04-07 14:03:34 +00:00 by SenseiKiwi · 0 comments
SenseiKiwi commented 2014-04-07 14:03:34 +00:00 (Migrated from github.com)
Copy Link

I don't have much time to go into detail about this so I'll have to make it quick. Our code seems to be reliant on door-type blocks and doesn't support trapdoors properly. For instance, placing a Dimensional Door, then breaking it and attaching a Transdimensional Trapdoor causes an exception and the door slams shut. I'm fairly certain that other issues would arise if that code could continue running. At some point, traverseDimDoor() got a parameter "Block door". A lot of code seems to assume that block is going to be a normal door and not a trapdoor.

I also noticed that some function in PocketBuilder requires us to sent it a Block that implements IDimDoor. Maybe we should consider changing the parameter to BaseDimDoor? Or at least BlockDoor. Especially if we're going to use ItemDoor to place the block.

I don't have much time to go into detail about this so I'll have to make it quick. Our code seems to be reliant on door-type blocks and doesn't support trapdoors properly. For instance, placing a Dimensional Door, then breaking it and attaching a Transdimensional Trapdoor causes an exception and the door slams shut. I'm fairly certain that other issues would arise if that code could continue running. At some point, traverseDimDoor() got a parameter "Block door". A lot of code seems to assume that block is going to be a normal door and not a trapdoor. I also noticed that some function in PocketBuilder requires us to sent it a Block that implements IDimDoor. Maybe we should consider changing the parameter to BaseDimDoor? Or at least BlockDoor. Especially if we're going to use ItemDoor to place the block.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
apex
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: apex/DimDoors#150
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?