Ninja Semicolon in EventHookContainer #145

New Issue

2014-03-26T06:50:04Z

SenseiKiwi commented

2014-03-26 06:50:04 +00:00

(Migrated from github.com)

Found this semicolon while checking through our recent changes: https://github.com/StevenRS11/DimDoors/blob/master/src/main/java/StevenDimDoors/mod_pocketDim/EventHookContainer.java#L78

It's old, though I'm not sure how old. I don't want to just erase it out of concern of the impact that it could have. That music code has been causing crashes for some users and I honestly have no idea how it works. I patched it once to prevent a crash that someone reported, but that's it. Please sort out if that code works right.

Found this semicolon while checking through our recent changes: https://github.com/StevenRS11/DimDoors/blob/master/src/main/java/StevenDimDoors/mod_pocketDim/EventHookContainer.java#L78 It's old, though I'm not sure how old. I don't want to just erase it out of concern of the impact that it could have. That music code has been causing crashes for some users and I honestly have no idea how it works. I patched it once to prevent a crash that someone reported, but that's it. Please sort out if that code works right.

SenseiKiwi commented

2014-07-08 08:44:50 +00:00

(Migrated from github.com)

This issue was fixed.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: apex/DimDoors#145