apex/DimDoors
1
1
Fork 0
Code Issues 26 Pull Requests Actions Packages Projects Releases Wiki Activity

Dimdoors dims save too often #102

New Issue
Closed
opened 2013-11-17 09:18:36 +00:00 by ZexMaxwell001 · 2 comments
ZexMaxwell001 commented 2013-11-17 09:18:36 +00:00 (Migrated from github.com)
Copy Link

I keep seeing my server console saving about every other min even though no one is currently using the doors or on the server.

Forge 952 1.6
no server impact at this moment.

I keep seeing my server console saving about every other min even though no one is currently using the doors or on the server. Forge 952 1.6 no server impact at this moment.
SenseiKiwi commented 2013-12-21 19:04:52 +00:00 (Migrated from github.com)
Copy Link

This is straightforward to fix. The reason that the messages appears every so often is because we save the rift-related data for each dimension every time the world saves. This happens every 30 seconds, I think. We output a message saying that saving is taking place, but assuming our dirty flags are working right, no actual saving is taking place. We should only save data for dimensions that have had their data change recently. The solution to the log spam would be not to output messages unless we actually do save something, or perhaps we shouldn't do it at all.

This is straightforward to fix. The reason that the messages appears every so often is because we save the rift-related data for each dimension every time the world saves. This happens every 30 seconds, I think. We output a message saying that saving is taking place, but assuming our dirty flags are working right, no actual saving is taking place. We should only save data for dimensions that have had their data change recently. The solution to the log spam would be not to output messages unless we actually do save something, or perhaps we shouldn't do it at all.
StevenRS11 commented 2013-12-26 19:01:15 +00:00 (Migrated from github.com)
Copy Link

SenseiKiwi Fixed

SenseiKiwi Fixed
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
apex
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: apex/DimDoors#102
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?