apex/DimDoors
1
1
Fork 0
Code Issues 26 Pull Requests Actions Packages Projects Releases Wiki Activity

Cleaned Up Code

Browse Source 
Deleted PlayerRespawnTracker and removed all references to it - we
weren't going to use it anymore anyway. Renamed IDDoorLogic to IDimDoor
- abbreviating the "Dim" as D next to the standard I for Interface is
confusing. Renamed DDoorBase to BaseDimDoor and made it into an abstract
class - that's effectively what it was supposed to be. We should be
declaring methods as abstract rather than using empty ones. I renamed
the class because the convention for naming abstract classes is to start
the name with Base. Cleaned up code in other files.
This commit is contained in:
SenseiKiwi
2013-09-06 20:57:00 -04:00
parent f2ff5f79cc
commit a0454351d5
10 changed files with 79 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
StevenDimDoors/mod_pocketDim/blocks/WarpDoor.java
View File

@@ -1,29 +1,19 @@
package StevenDimDoors.mod_pocketDim.blocks;
import java.util.Random;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.Entity;
import net.minecraft.item.Item;
import net.minecraft.util.Icon;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import StevenDimDoors.mod_pocketDim.mod_pocketDim;
import StevenDimDoors.mod_pocketDim.DDProperties;
import StevenDimDoors.mod_pocketDim.core.DimLink;
import StevenDimDoors.mod_pocketDim.core.LinkTypes;
import StevenDimDoors.mod_pocketDim.core.NewDimData;
import StevenDimDoors.mod_pocketDim.core.PocketManager;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
public class WarpDoor extends DDoorBase implements IDDoorLogic
public class WarpDoor extends BaseDimDoor
{
private Icon blockIconBottom;
public WarpDoor(int blockID, Material material)
public WarpDoor(int blockID, Material material, DDProperties properties)
{
super(blockID, material);
super(blockID, material, properties);
}
@Override
@@ -33,7 +23,7 @@ public class WarpDoor extends DDoorBase implements IDDoorLogic
{
NewDimData dimension = PocketManager.getDimensionData(world);
DimLink link = dimension.getLink(x, y, z);
if (link == null&&dimension.isPocketDimension())
if (link == null && dimension.isPocketDimension())
{
dimension.createLink(x, y, z, LinkTypes.SAFE_EXIT);
}
@@ -45,6 +35,4 @@ public class WarpDoor extends DDoorBase implements IDDoorLogic
{
return Item.doorWood.itemID;
}
}