Fixed Configuration and Rift Generation Bugs

Although fields were created in DDProperties for Monolith spawning and
Rift generation, they were mislabeled as reading the "World Rift
Generation Enabled" property. I gave them proper names. I also changed
the fields and names to be more intuitive and rewrote the descriptions.
For instance, "MonolithSpawnDensity" is a misnomer because as density
increases, there should be more Monoliths, not less. Now the properties
clearly state how they affect a feature. I rewrote the conditions that
used each property to correspond with those simplified descriptions and
gave the properties default values that will match the generation rates
seen before.

I also made the rift generation code less cryptic and fixed a bug; there
was a check that compared if a dimension was a pocket dimension by its
name to prevent rift generation. That name check was wrong - it would
never work. Now we check if the provider is an instance of
pocketProvider. That will continue working even if we change the way
that pocket dimensions are named.

StevenDimDoors/mod_pocketDim/world/pocketProvider.java

@@ -15,112 +15,115 @@ import cpw.mods.fml.relauncher.Side;
 import cpw.mods.fml.relauncher.SideOnly;
 
 public class pocketProvider extends WorldProvider
-
 {
 	public int exitXCoord;
 	public int exitYCoord;
 	public int exitZCoord;
 	public int exitDimID;
 	public boolean hasNoSky = true;
-	
+
 	public boolean isSavingSchematic= false;
 	public int dimToSave;
 	private static DDProperties properties = null;
-	
+
 	public pocketProvider()
 	{
 		this.hasNoSky=true;
 		if (properties == null)
 			properties = DDProperties.instance();
 	}
-	
+
 	@Override
-    protected void registerWorldChunkManager()
-    {
+	protected void registerWorldChunkManager()
+	{
 		super.worldChunkMgr = new WorldChunkManagerHell(mod_pocketDim.pocketBiome,1,1);
-        //this.dimensionId = ConfigAtum.dimensionID;
-    }
+		//this.dimensionId = ConfigAtum.dimensionID;
+	}
+	
 	@Override
 	public String getSaveFolder()
-    {
-        return (dimensionId == 0 ? null : "DimensionalDoors/pocketDimID" + dimensionId);
-    }
-	
+	{
+		return (dimensionId == 0 ? null : "DimensionalDoors/pocketDimID" + dimensionId);
+	}
+
 	public void saveAsSchematic(int id)
 	{
 		this.isSavingSchematic=true;
 		this.dimensionId=id;
-		
+
 	}
-	
+
 	public Vec3 getSkyColor(Entity cameraEntity, float partialTicks)
 	{
-    	setCloudRenderer( new CloudRenderBlank());
-        return this.worldObj.getWorldVec3Pool().getVecFromPool((double)0, (double)0, (double)0);
+		setCloudRenderer( new CloudRenderBlank());
+		return this.worldObj.getWorldVec3Pool().getVecFromPool((double)0, (double)0, (double)0);
 
 	}
-	
-	
-	 
-    @SideOnly(Side.CLIENT)
+
+
+
+	@SideOnly(Side.CLIENT)
 	@Override
 	public Vec3 getFogColor(float par1, float par2)
-    {
-        return this.worldObj.getWorldVec3Pool().getVecFromPool((double)0, (double)0, (double)0);
+	{
+		return this.worldObj.getWorldVec3Pool().getVecFromPool((double)0, (double)0, (double)0);
+
+	}
 
-    }
 	@Override
 	public double getHorizon()
-    {
-        return worldObj.getHeight();
-    }
+	{
+		return worldObj.getHeight();
+	}
+
 	@Override
 	public IChunkProvider createChunkGenerator()
 	{
 		return new pocketGenerator(worldObj, dimensionId, false);
 	}
-	 @Override
-	    public boolean canSnowAt(int x, int y, int z)
-	    {
-	        return false;
-	    }
-	 public boolean canBlockFreeze(int x, int y, int z, boolean byWater)
-	    {
-	        return false;
-	    }
+
+	@Override
+	public boolean canSnowAt(int x, int y, int z)
+	{
+		return false;
+	}
+	
+	public boolean canBlockFreeze(int x, int y, int z, boolean byWater)
+	{
+		return false;
+	}
 
 	@Override
 	public String getDimensionName() 
 	{
+		//TODO: This should be a proper name. We need to show people proper names for things whenever possible.
+		//The question is whether this should be "Pocket Dimension" or "Pocket Dimension #" -- I'm not going to change
+		//it out of concern that it could break something. ~SenseiKiwi
 		return "PocketDim " + this.dimensionId;
 	}
-	
-	
+
 	public int getRespawnDimension(EntityPlayerMP player)
 	{
 		int respawnDim;
-		
+
 		if (properties.LimboEnabled)
 		{
 			respawnDim = properties.LimboDimensionID;
 		}
 		else
 		{
-			respawnDim= dimHelper.dimList.get(this.dimensionId).exitDimLink.destDimID;
+			respawnDim = dimHelper.dimList.get(this.dimensionId).exitDimLink.destDimID;
 		}
-		
-		if (dimHelper.getWorld(respawnDim)==null)
+
+		if (dimHelper.getWorld(respawnDim) == null)
 		{
 			dimHelper.initDimension(respawnDim);
 		}
 		return respawnDim;
 	}
-	
-	 public boolean canRespawnHere()
-	    {
-	        return false;
-	    }
-
-	
 
+	public boolean canRespawnHere()
+	{
+		return false;
+	}
 }